[Toybox] patch to disable scripts/make.sh GITHASH=...

Felix Janda felix.janda at posteo.de
Sun Aug 6 04:17:28 PDT 2017


Thomas wrote:
> > Wait, your git --describe is finding a random tarball in some other
> > directory?
> >
> > That's really broken.
> ...
> > That's a pretty clear yocto bug (one I can't reproduce), but if you're
> > adding a workaround for this yocto bug the easy thing to do is keep
> > GITHASH if it's already be set, not add a second special case variable.
> 
> Replace "yocto" with "project using git + building toybox"
> 
> make.sh sets GITHASH because the "." directory is "under" git.
> /proj/whatever/ ... was checked out of git and contains:
> /proj/whatever/things/toybox/download-build-toybox.sh
> ... "git describe --tags --abbrev=12" prints out the tag/hash
> for parent project whatever ... not for toybox.tgz.
> 
> GITHASH is technically correct, but annoyingly unhelpful.
> 
> How shall I force "toybox --version" to print "toybox 0.7.4"
> instead of "toybox whatever-16.0.0-222-ge7bb9e918200"
> just because the toybox build dir is "under" a git dir?

Have you looked at the GIT_CEILING_DIRECTORIES variable?

Felix



More information about the Toybox mailing list