[Toybox] mkroot works again, pending release.

[Patrick Oppenlander]

On Mon, Oct 26, 2020 at 12:56 PM Rob Landley <rob at landley.net> wrote:
>
> On 10/25/20 7:57 PM, Patrick Oppenlander wrote:
> > On Mon, Oct 26, 2020 at 11:46 AM Rob Landley <rob at landley.net> wrote:
> >>
> >> On 10/25/20 6:39 PM, Patrick Oppenlander wrote:
> >>> On Sat, Oct 24, 2020 at 12:43 PM Rob Landley <rob at landley.net> wrote:
> >>>>
> >>>> On 10/20/20 11:19 PM, Rob Landley wrote:
> >>>>> On 10/20/20 10:03 PM, Patrick Oppenlander wrote:
> >>>>>> On Wed, Oct 21, 2020 at 1:38 PM Rob Landley <rob at landley.net> wrote:
> >>>>>>> So yeah, allyesconfig throws #warnings during the build for a reason. I forgot
> >>>>>>> people test like that.
> >>>>>>
> >>>>>> Well that was a lucky coincidence then.
> >>>>>>
> >>>>>> I initially observed the issue on my ARMv7-M NOMMU target.
> >>>>>> "allyesconfig" was the closest hammer to get a toybox build with sh on
> >>>>>> my host, and just happened to also show the same behaviour.
> >>>>>>
> >>>>>> Thanks for looking into it.
> >>>>>
> >>>>> I do need to fix nommu subshells, yes. Good bug report. But fixing it might be
> >>>>> out of scope for this release.
> >>>>
> >>>> It was specifically a -c bug, nommu subshells worked fine in other contexts but
> >>>> when nommu toysh was relaunching itself it didn't NOT parse -c so it ran that
> >>>> same command again in the new subshell, which spawned ANOTHER subshell, which...
> >>>>
> >>>> Try now?
> >>>
> >>> Looks like it still isn't working.
> >>
> >> $ ./sh -c 'echo $(echo hello)'
> >> hello
> >>
> >> It is for me, with nommu support enabled? What's your test and what are you seeing?
> >
> > Yep, with nommu support enabled, here's the steps I took:
> >
> > % git describe --tags
> > 0.8.4
> > % make defconfig
> > % make menuconfig
> >
> > switch on pending/sh
> > switch on Toybox global settings/Enable nommu...
> > save
> >
> > % make
> > % ./toybox sh -c 'echo $(echo hello)'
> >
> > gives a blank result.
>
> And does not for me, as I said, so this is insufficient reproduction sequence
> for me to see your issue.

Sorry, didn't realise that was the case.

> Architecture? Toolchain? libc? Attach your .config?

x86_64
Arch Linux
gcc 10.2.0 glibc (distro default)

I can give you a shell account on a machine running that setup if it helps.

.config attached.

Patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config
Type: application/octet-stream
Size: 7128 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20201026/4c8853b7/attachment-0003.obj>