[Toybox] [landley/toybox] Add "ifconfig eth0 rename NEWNAME". (f22bec1)

[enh]

On Fri, Apr 15, 2022 at 6:26 PM Rob Landley <rob at landley.net> wrote:

> On 4/15/22 18:10, enh wrote:
> > yeah, and it seems to have passed on github CI anyway, so i didn't
> notice until
> > i tried to update AOSP.
> >
> > maybe those tests are just skipped on github?
> >
> >   SKIP: ifconfig (not root)
> >
> > yep. (ideally i'd run the tests _twice_ on Android: once as root and
> once not as
> > root, but that's a lot harder and hasn't bitten us _yet_ so "just as
> root" it is...)
>
> Root should be a strict superset of the non-root tests. It shouldn't test
> anything extra NOT as root.
>

yeah, we've just had cases where stuff works for root but not for non-root.
("we" being Android here; i can't off-hand think of a toybox example?)


> >     I'll add a comment line.
> >
> > thanks! let me know when it's in and i'll try another sync...
>
> It's in.
>

and that seems to have been the last issue ... merged in AOSP.

this will probably be the toybox that's in Android T, unless there's an
urgent regression to cherrypick or something!


> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20220418/a2eeec88/attachment-0001.htm>