[Toybox] [PATCH] xargs: open child's stdin non-O_CLOEXEC.

[enh]

On Fri, Apr 22, 2022 at 12:30 AM Rob Landley <rob at landley.net> wrote:

> On 4/21/22 19:58, enh via Toybox wrote:
> > O_CLOEXEC is the default in toybox, so although the code as written
> > _looked_ correct, we need to |O_CLOEXEC to have the fd survive the
> > exec().
>
> Oops.
>
> > Found by folks building the kernel with toybox.
>
> Yay!
>
> I'm building the kernel with toybox for a bunch of architectures here, and
> didn't see it. I'm curious what context the breakage was in?
>

yeah, sorry, i did add the link to the commit message but it was so long i
took it back out again. aiui they were trying this:

https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/scripts/gen_autoksyms.sh?h=kbuild&id=2f6b64906adf99b4c5ea9356df793766d290cfb4

if you're thinking "i thought Android didn't allow kernel modules", that
_was_ true, but part of the Generic Kernel Image (GKI) stuff is that every
device should have the same kernel ... with modules being the escape hatch.
(which then means everyone working in that area is worried about ABI one
way or another!)


> Thanks,
>
> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20220422/46514526/attachment-0001.htm>