[Toybox] ToyBox ?: gcc extension excision

Rob Landley rob at landley.net
Tue Apr 10 00:26:50 PDT 2012


On 04/08/2012 04:06 PM, Georgi Chorbadzhiyski wrote:
> On 4/8/12 5:12 AM, Rob Landley wrote:
>> On 04/07/2012 12:25 PM, Kevin Chase wrote:
>>> Hi Rob,
>>>
>>> Just poking toybox lightly, and noticed a gcc extension in the code (x ?
>>> : y for x ? x : y).  I assume you want to support other compilers, so
>>> here's a removal patch.
>>
>> Huh.  I think Georgi built the thing with llvm, I don't remember him
>> having to remove that?  But I'm _still_ not caught up with his patch
>> backlog.  (I spent the past month buying a house, relatives are visiting
>> this week... The usual.)
>>
>> If those are the only two occurrences of the thing I might as well
>> remove it, but does this actually make it build somewhere it didn't
>> before?  (llvm? pcc? I know tinycc already supports this extension...)
> 
> clang (llvm 2.9) compiles this gcc extension without problems, but I don't
> think the extension brings much to keep using it.

You're right.  Ok, I'll check in Kevin's changes.

Rob
-- 
GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code.
Either it's "mere aggregation", or a license violation.  Pick one.



More information about the Toybox mailing list