[Toybox] vmstat spring clean
Elie De Brauwer
eliedebrauwer at gmail.com
Wed Apr 11 10:16:18 PDT 2012
All,
You can find in attachment an enhancement of the vmstat code (with
respect to what's upstream). This includes:
- spaces/tabs cleanup (mea culpa)
- toybuf buffer issues (using xread iso fdlength, and add zero byte at
the end (nice catch btw) )
- query the terminal height and update this.
W.r.t. this last one, i only perform the query after printing a header
so not every loop so there is some transition from going to extremely
large to extremely small terminal heights. But vmstat isn't doing a
great job at handling that either. I also think that if this call fails
on serial consoles, perhaps it makes sense to have teh ascii probing
implemented in the library itself?
my 2 cents
E.
--
Elie De Brauwer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vmstat-cleanup.patch
Type: text/x-patch
Size: 13356 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20120411/7bc43ae1/attachment-0006.bin>
More information about the Toybox
mailing list