[Toybox] New toy: mknod

Elie De Brauwer eliedebrauwer at gmail.com
Mon Feb 13 11:12:05 PST 2012


Hi all,

In attachment you can find a new version of mknod. Two small comments:
1. mknod uses this awkward non-getopt-like syntax (you know mknod 
/dev/null c 1 3) for now I'm using optargs for all of them with a limit 
stating the number of arguments should be between 2 and 4.  If anybody 
could point into ways in which the argument parsing could be more 
helpful that would be appreciated.
2. mknod typically has support for passing the mode with -m, I haven't 
added this (yet) (and if you want it just chmod it afterwards, oh, right 
chmod isn't there yet either), but I think that it might be worth to 
extend argument passing in lib/args.c for reading modes, at least chmod 
would already benefit from that too.

my 2 cents
E.

-- 
Elie De Brauwer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: adding_mknod.patch
Type: text/x-patch
Size: 2276 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20120213/4d4dc39f/attachment-0001.bin>


More information about the Toybox mailing list