[Toybox] [PATCH] newtoy: kill
Rob Landley
rob at landley.net
Tue Feb 21 17:46:44 PST 2012
On 02/19/2012 10:55 AM, Daniel Walter wrote:
> Hi,
>
> I've implemented a SUS compliant kill command.
>
> Comments and suggestions are welcome.
Cool.
I note that "killall" already has about half this infrastructure. And
you're not using any of toybox's option parsing code:
http://landley.net/toybox/code.html#lib_args
Also, kill needs to be able to integrate with the shell's job support,
so you can kill a background job. I'm not sure how to handle that, the
relevant shell bits haven't been written yet...
That said, I can merge this, factor out the common killall and option
parsing bits, and then worry about shell integration later.
Thanks,
Rob
More information about the Toybox
mailing list