[Toybox] sort.c patch, was: Re: PM: code style, was: Re: New Subscriber

Rob Landley rob at landley.net
Mon Feb 13 19:45:10 PST 2012


On 02/08/2012 04:36 AM, Frank Bergmann wrote:
> On Wed, Feb 08, 2012 at 09:00:10AM +0100, Frank Bergmann wrote:
>> clone done. Patches submit to the list?
>> My first make did throw the nasty "dereferencing type-punned pointer will
>> break strict-aliasing rules". In sort.c you use TT.lines as char* and not
>> char**.
> 
> Here's the stuff:

Unfortunately, when I cut and paste the patch you sent, the result is
whitespace damaged (all tabs expanded to spaces) so doesn't apply
cleanly, and when I save the email I get:

Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: toybox-bounces at lists.landley.net
Sender: toybox-bounces at lists.landley.net

T24gV2VkLCBGZWIgMDgsIDIwMTIgYXQgMDk6MDA6MTBBTSArMDEwMCwgRnJhbmsgQmVyZ21hbm4g
d3JvdGU6Cj4gY2xvbmUgZG9uZS4gUGF0Y2hlcyBzdWJtaXQgdG8gdGhlIGxpc3Q/Cj4gTXkgZmly
c3QgbWFrZSBkaWQgdGhyb3cgdGhlIG5hc3R5ICJkZXJlZmVyZW5jaW5nIHR5cGUtcHVubmVkIHBv
aW50ZXIgd2lsbAo+IGJyZWFrIHN0cmljdC1hbGlhc2luZyBydWxlcyIuIEluIHNvcnQuYyB5b3Ug
dXNlIFRULmxpbmVzIGFzIGNoYXIqIGFuZCBub3QKPiBjaGFyKiouCgpIZXJlJ3MgdGhlIHN0dWZm

And so on...

Luckily it's simple enough to apply by hand, but we might want to
resolve this for future patches...

Rob

 1329191110.0


More information about the Toybox mailing list