[Toybox] [PATCH] newtoy: kill

[Daniel Walter]

On Tue, Feb 21, 2012 at 07:46:44PM -0600, Rob Landley wrote:
> On 02/19/2012 10:55 AM, Daniel Walter wrote:
> > Hi,
> > 
> > I've implemented a SUS compliant kill command.
> > 
> > Comments and suggestions are welcome.
> 
> Cool.
> 
> I note that "killall" already has about half this infrastructure.  And
> you're not using any of toybox's option parsing code:
> 
>   http://landley.net/toybox/code.html#lib_args
> 
> Also, kill needs to be able to integrate with the shell's job support,
> so you can kill a background job.  I'm not sure how to handle that, the
> relevant shell bits haven't been written yet...
> 
> That said, I can merge this, factor out the common killall and option
> parsing bits, and then worry about shell integration later.
> 
> Thanks,
> 
> Rob

I wrote kill just before killall was pushed into your repo, so some code 
is duplicated.

I did try to use lib_args but I ran into multiple problems when trying to
use it and allow -HUP or any other -SIGNALNAME, so I gave up and did it
the way I submitted it. 

btw I have seen toybox on github (https://github.com/landley/toybox) but it
is empty. Any plans to move the code there ?

regards,

daniel

 1329926171.0