[Toybox] New toys - chmod, chown and chgrp

Rob Landley rob at landley.net
Tue Mar 13 19:08:44 PDT 2012


On 02/29/2012 08:40 AM, Georgi Chorbadzhiyski wrote:
> Ok, these were not so hard. There is a possibility of code sharing, because
> most of the code is copy and pasted between these and adding support for the
> missing options in chown and chgrp will only increase code duplication.
> 
> I'll unify most of the code in these toys somewhere under lib (dirtree.c probably).
> It looks like in order things to work I'll need to add one void * parameter to callback
> function passed to dirtree_read() and possibly flags parameter to dirtree_read() itself
> (I want to silence printed warnings for example).
> 
> How is that for a plan?

It sounds like a good plan, and I am slowly catching up with it. :)

Rob



More information about the Toybox mailing list