[Toybox] [PATCH] Support coreutils extensions in toys/sleep.c

Rob Landley rob at landley.net
Sat Mar 3 21:47:53 PST 2012


On 02/27/2012 06:28 PM, Georgi Chorbadzhiyski wrote:
> The attached patch adds support for all features supported by coreutils'
> sleep program.

Applied.

Code review:

GNU is as irrelevant to toybox as Microsoft, I'd rather not mention
either unless there's a good reason.  I've got a TOYBOX_FOAT symbol for
enabling/disabling floatin gpoint support.

The period isn't necessarily a prefix, 2.5 seconds is a valid wait. The
period and the suffix aren't exclusive either, 0.1m is another way of
saying 6s. And there's no reason 5.5 shouldn't work, even though usleep
maxes out somewhere around 2.7 seconds I think...

Rob

 1330840073.0


More information about the Toybox mailing list