[Toybox] [CLEANUP] stat: Some cleanup

[Rob Landley]

On 04/21/2013 04:40:16 PM, Felix Janda wrote:
> > If you can come up with a clean way to share the code, go for it.
> 
> Ok, actually I'd only put something like get_access_str() of stat into
> the lib.

Cool. Although a quick glance at the one in stat implies it doesn't  
handle the fun combinations of "suid and sgid bits without  
corresponding executable bit when applied to a directory so it's the  
sticky bit" that I had to make work in ls.

   stat /dev/null
   stat /tmp

So if you actually need that behavior you'll need the blob of ls  
starting around line 340...

> > I'm leaning against it. If you saw my toybox talk at ELC (it's on
> > youtube) I talked about security approaches and containers vs  
> selinux.
> 
> I anticipated that (and read your outline and skimmed the video). So  
> it
> would be ok to remove the SELinux parts from the command (which anyway
> only say that they are not implemented)?

Yes.

> Should "%T" be implemented?

I'd wait for somebody to complain about its absence.

Rob
 1366605008.0