[Toybox] [PATCH] python2 probing

[Elie De Brauwer]

Hi Rob, list,

When I try building tip currently (make clean; make defconfig; make ),
the compilation aborts with:

Compile toybox...
lib/help.c:8:28: fatal error: generated/help.h: No such file or directory
compilation terminated.
make: *** [toybox] Error 1

On my system this is because make.sh contains

PYTHON="$(which python2)"
if [ ! -z "$PYTHON" ] &&
   [ ! -z "$(grep 'CONFIG_TOYBOX_HELP=y' $KCONFIG_CONFIG)" ]
then
  echo "Extract help text from Config.in."
  "$PYTHON" scripts/config2help.py Config.in > generated/help.h || exit 1
fi


But my system (Debian 7.0) has no python2 symlink. It actually does
have python2.6 and python2.7 symlinks. So I would at least advice to
check for any of the earlier to exist, rather than python2.

Another issue is that it's not very graceful in error handling.

Attached you can find a patch which searches for python, python2.6 and
python2.7 (in that order) and prints out a friendly warning if the
user requested help but python2.x could not be found.

my 2 cents
E.

-- 
Elie De Brauwer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: python_probe.patch
Type: application/octet-stream
Size: 1259 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20130831/50da4e7a/attachment-0006.obj>