[Toybox] [New Toy] - groupdel

Rob Landley rob at landley.net
Mon Dec 23 05:24:06 PST 2013


On 11/25/2013 06:35:17 AM, Ashwini Sharma wrote:
> Hi Rob, list,
> 
> Attached is an implementation for groupdel.
> 
> This is aliased to delgroup, for a requirement at my end.
> Also lib/password.c is modified to along with.

Applied, but let me just say:

        } else if (!strcmp(toys.which->name, "groupadd") ||
-          !strcmp(toys.which->name, "addgroup")){
+          !strcmp(toys.which->name, "addgroup") ||
+          !strcmp(toys.which->name, "delgroup") ||
+          !strcmp(toys.which->name, "groupdel")){

Ick. (Not a _new_ ick, but still.)

Someday, I need to do a proper cleanup of the passwd infrastructure.  
Until then, lib/password.c is basically an extension of lib/pending.c...

Thanks,

Rob


More information about the Toybox mailing list