[Toybox] [New Toy] - modprobe

ibid.ag at gmail.com ibid.ag at gmail.com
Thu Dec 19 08:31:17 PST 2013


On Thu, Dec 19, 2013 at 11:28:17AM +0530, Ashwini Sharma wrote:
> Hi,
> 
> comments inline...
> 
> attached is the modified file.
> this also includes the fix for alias loading. There was an error in
> modprobe_main().
> 
> llist_pop() returns the struct ag_list*, whereas this was assigned to
> char*, which is modified
> as below.
> 
>       char *real = ((struct arg_list*)llist_pop(&module->rnames))->arg;
>       struct module_s *m2 = get_mod(real, 0);
> 
> regards,
> Ashwini

Looks good for a first version.
And yes, it fixes alias loading.

Thanks,
Isaac Dunham

 1387470677.0


More information about the Toybox mailing list