[Toybox] recent cp checkins

[milto57 at attglobal.net]

Hi Rob.

New account, let the spam begin (NOT) :-)

When you added the help for cp  -n I noticed the
help for -p is missing, even though the help -a
refers to it.  Now I notice a few others are also
undocumented.

Also, this looks suspicious:
http://landley.net/hg/toybox/rev/5bc258a4c750

    1.22 +    // Detect recursive copies via
repeated top node (cp -R .. .) or
    1.23 +    // identical source/target (fun with
hardlinks).
    1.24 +    if ((TT.top.st_dev == try->st.st_dev
&& TT.top.st_ino == try->st.st_ino
    1.25 +         && (catch = TT.destname))
    1.26 +        || (!fstatat(cfd, catch, &cst,
0) && cst.st_dev == try->st.st_dev
    1.27 +         && cst.st_ino == try->st.st_ino))

Because the first if that assigns catch is highly
conditional and the second half uses it
unconditionally.


 1357994656.0