[Toybox] (no subject)

[Rob Landley]

On 07/19/2013 05:02:40 AM, Ashwini Sharma wrote:
> Hi Rob,
> 
>    Attached is the syslogd patch. Features supported are
> 
> usage: syslogd  [-a socket] [-p socket] [-O logfile] [-f config file]  
> [-m
> interval]
> [-p socket] [-s SIZE] [-b N] [-R HOST] [-l N] [-nSLKD]
> 
> In this implementation, __/dev/log__ is used as the default input  
> source
> and __/var/log/messages__ as the default
> output destination.

The second one is in accordance with <strike>the prophecy</strike>  
Filesystem Hirearchy Standard 2.3:

http://refspecs.linuxbase.org/FHS_2.3/fhs-2.3.html#VARLOGLOGFILESANDDIRECTORIES

The first one isn't in FHS, and devtmpfs with Aboriginal's kernel  
config isn't providing "log". (It's providing "kmsg", but I dunno if  
that's the same thing.) Where does this data source come from and how  
would I set it up in my own system? (I'm not objecting, I'd just like  
to document how to use it.)

> Please review and apply the patch to hg, and let me know for any  
> comments.

I applied this and the other two commands to the pending directory. I  
didn't apply the previous batch's libc or makefile changes yet.

For libc I mentioned that the ordering was used for fatal vs non-fatal  
signals, and restricted itself to the signals specified by POSIX-2008.  
This is adding realtime support (not in posix that I recall), and I  
need to work out how to do that cleanly and test it against glibc,  
uClibc, musl, and (if I can get a fourth test environment set up)  
bionic.

As for the makefile changes: it's filtering out space during flag  
generation. Easier thing to do would be to filter out space in  
getflags, by adding a space character to the sed invocation:

--- a/scripts/make.sh	Thu Jul 25 13:32:06 2013 -0500
+++ b/scripts/make.sh	Thu Jul 25 13:41:00 2013 -0500
@@ -64,7 +64,7 @@
    sed -n -e "s/.*TOY($FLX"',[ \t]*"\([^"]*\)"[ \t]*,.*)/\1/' \
           -e 't keep;d;:keep' -e 's/^[<>=][0-9]//' -e 's/[?&^]//' \
           -e 't keep' -e 's/[><=][0-9][0-9]*//g' -e 's/+.//g' \
-         -e 's/\[[^]]*\]//g' -e 's/[-?^:&#|@*]//g' "$@" -e 'p'
+         -e 's/\[[^]]*\]//g' -e 's/[-?^:&#|@* ]//g' "$@" -e 'p'
  }

Let's see: grep NEWTOY toys/*/*.c | grep '"[^" ]* [^" ]*"'

I see that kill and timeout are both affected by this. Flags look right  
now, and I _really_ need to fill out the test suite to catch this sort  
of thing... Anyway, commiting the smaller fix.

> regards,
> Ashwini

Thanks,

Rob