[Toybox] [PATCH] inline CRC64 checks in xzcat

Rob Landley rob at landley.net
Fri Jul 5 23:27:47 PDT 2013


I have no idea when this email is actually going to _send_. I'm at  
another convention this weekend (with my sister instead of Fade this  
time), and it has no internet. The hotel I'm at blocks port 25 on  
outgoing email (presumably because of spam problems?). I tried using  
netcat to tunnel ssh to my webserver and _that_ is blocking port 25.

Sigh. I'd go to a coffee shop but my car's still in Texas...

Anyway, the reply:

On 07/03/2013 12:17:10 AM, Isaac wrote:
> This inlines CRC64, and nothing more.
> The functions involved were called only once.

Is this the only thing that's going to use CRC64? There were a lot of  
users of crc32, and I'd like to add sha3 and so on...

*shrug* Applied in the meantime, but we might have to undo this one  
again in future and move it to /lib...

> --
> Tested to build and to decompress a tarball
> (./toybox xzcat < some.tar.xz |shasum; xzcat <some.tar.xz |shasum)
> Patch is against 0.4.5/commit 942.
> 
> I intend to remove XZ_PREALLOC/XZ_SINGLE, since we're not using them  
> and
> probably won't due to how low-level they are.
> Also on my agenda is changing the main loop to recognize filenames,
> probably via loopfiles() like bzcat does.

Sounds good.

Rob
 1373092067.0


More information about the Toybox mailing list