[Toybox] [TOY] lspci

[Rob Landley]

On 07/22/2013 02:05:26 PM, Felix Janda wrote:
> > 75 lines total.
> 
> Down to 70 after application of the below patch with small fixes.
> 
> It felt more sensible to me to read 2 more bytes and ignore them than  
> to
> seek for 2 bytes in a file. So preadat_name now has one argument less.
> 
> Use calloc instead of malloc + memset. With this also the off-by-one
> error from (origninally) line 32 is fixed. It would be nice to use
> toybuf for this, wouldn't it? That would also make valgrind happier.
> 
> Print "" instead of "." when .../driver is missing.
> 
> The only difference between the usual output and the machine readable
> output is the format string. Use this to avoid some repetition.
> 
> Felix

patching file toys/pending/lspci.c
Hunk #2 FAILED at 32.
Hunk #3 succeeded at 65 (offset 1 line).
1 out of 3 hunks FAILED -- saving rejects to file  
toys/pending/lspci.c.rej

Did I miss an intermediate patch? Could you send me a fresh one that  
applies to my current tree?

(Catching up on the backlog...)

Thanks,

Rob
 1374885904.0