[Toybox] toybox: Rough edges in pending

[Isaac Dunham]

Hello,
I don't expect these to be very high priority, but I ran into a few rough edges when enabling almost all the toys in pending:
-sh:
toys/pending/sh.c: In function 'run_pipeline':
toys/pending/sh.c:303: warning: assignment from incompatible pointer type
Apparently, gcc doesn't recognize both rebound and toys.rebound

Also, when toybox is built with musl, and toybox sh executes ls, I get a hang; strace indicates that something funny is going on:

execve("./toybox-musl", ["./toybox-musl", "sh", "-c", "ls"], [/* 22 vars */]) = 0
getuid32()                              = 1000
geteuid32()                             = 1000
umask(0)                                = 022
umask(022)                              = 0
getuid32()                              = 1000
geteuid32()                             = 1000
brk(0)                                  = 0x8081000
brk(0x8082000)                          = 0x8082000
umask(0)                                = 022
umask(022)                              = 0
ioctl(0, SNDCTL_TMR_TIMEBASE or TCGETS, {B9600 opost isig icanon echo ...}) = 0
vfork(Config.in README    kconfig scripts     toybox_unstripped toys.h 
LICENSE   configure lib     toybox      toynet.h          www    
Makefile  generated main.c  toybox-musl toys              
)                                 = 27832
--- SIGCHLD (Child exited) @ 0 (0) ---
wait4(27832, [{WIFEXITED(s) && WEXITSTATUS(s) == 0}], 0, NULL) = 27832
pause(^C <unfinished ...>

With glibc, that last is:
ioctl(0, SNDCTL_TMR_TIMEBASE or TCGETS, {B9600 opost isig icanon echo ...}) = 0
vfork(Config.in README    kconfig scripts     toybox_unstripped toys.h 
LICENSE   configure lib     toybox      toynet.h          www    
Makefile  generated main.c  toybox-musl toys              
)                                 = 27838
waitpid(27838, [{WIFEXITED(s) && WEXITSTATUS(s) == 0}], 0) = 27838
--- SIGCHLD (Child exited) @ 0 (0) ---
exit_group(1)                           = ?

I anticipate this is a bug in musl, so I'll cross-post.



Thanks,
Isaac Dunham <idunham at lavabit.com>