[Toybox] xargs with blank input

Rob Landley rob at landley.net
Thu Oct 31 07:34:45 PDT 2013


On 10/16/2013 02:16:47 PM, William Haddon wrote:
> diff --git a/toys/posix/xargs.c b/toys/posix/xargs.c
> index e1611ec..6238af8 100644
> --- a/toys/posix/xargs.c
> +++ b/toys/posix/xargs.c
> @@ -160,17 +160,16 @@ void xargs_main(void)
>      if (data && !TT.entries) error_exit("argument too long");
>      out = xzalloc((entries+TT.entries+1)*sizeof(char *));
> 

This patch doesn't apply, and the reason it doesn't apply is... odd.

See how those first two lines are indented six spaces each? The first  
space signals patch "look for this existing line", the remaining spaces  
are the indent on the line. But toybox uses two space indents. The if  
line below is indented four spaces:

> -    if (dlist) {

But those first two are indented _five_.

I'm confused?

Rob
 1383230085.0


More information about the Toybox mailing list