[Toybox] [Patch] - bug in lib function lskip()

Ashwini Sharma ak.ashwini1981 at gmail.com
Wed Feb 26 04:34:30 PST 2014


Hi Rob, List,

In function __lskip()__

 or = readall(fd, libbuf, try);
     if (or < 0) perror_exit("lskip to %lld", (long long)offset);
-    else offset -= try;
+    else offset -= or;
     if (or < try) break;

offset is decremented by __try__ amount, whereas it should be decremented
by the actual amount read, i.e. __or__.

Attached is the patch.

regards,
Ashwini
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20140226/518cefad/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lib.c.patch
Type: application/octet-stream
Size: 309 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20140226/518cefad/attachment.obj>


More information about the Toybox mailing list