[Toybox] Build issue at changeset 1209:f170f978e81e

[Rob Landley]

On 02/26/14 06:30, Ashwini Sharma wrote:
> Hi Rob, List,
> 
> The code on mercurial at 
> 
> 
>       changeset 1209:f170f978e81e
> 
> is having build failures.
> This fails complaining about FLAG_x macros not being declared, starting
> from 
> __kill__ command.

Sigh, I didn't realize init with "" in the option string was checked in.

When toys/pending/init.c is enabled, the header flag generation gets
confused because "" doesn't register as a valid option string. (0 says
don't call the option parsing logic, "" would be call it and don't do
anything.) I know the scanf() can't handle it, looks like there's a
regex in make.sh that doesn't either. Both expect the quotes to have
something in them.

I'll try to fix it in the morning. Special case treating "" as 0,
probably. (Using 0 lets the option parsing logic drop out at compile
time for single command builds, because it's not used; "" doesn't.)

Thanks for the heads up,

Rob

 1393481287.0