[Toybox] [PATCH] Shut up GCC 3.4 on musl

[Rob]

ibid.ag at gmail.com wrote:
> Rob Landley wrote:
>> Isaac Dunham wrote:
>>>
>>> Two changes to shut up GCC:
>>> * __GLIBC__ was checked unconditionally;
>>> this made for a very messy build on musl.
>>
>> According to my C99 draft section 6.10.1.3:
>>
>>   After all replacements due to macro expansion and the defined unary
>>   operator have been performed, all remaining identifiers are replaced
>>   with the pp-number 0, and then each preprocessing token is converted
>>   into a token.
>>
>> That seems like a broken compiler? Still, portability.h is the place
>> to workaround that kind of breakage. But I'd prefer to isolate it to
>> its own stanza that blames the right thing so when we no longer care
>> about gcc 3.4 know to remove it instead of having Magic Thing.
>>
>
> I don't know if it's standards-conformant or not

gcc's behaviour is standards conformant - it's preprocessing the file
fine, there's just an additional warning that you're using an undefined
preprocessor identifier in #if. The warning isn't enabled by default, I
imagine it comes from -Wundef in the configure script, line 7.


Rob