[Toybox] [PATCH] cpio: fix -it

[Rob Landley]

On 03/26/14 12:13, Isaac Dunham wrote:
> Fix cpio -it: don't close(fd) unless we opened it.

Ooh, good catch. (Applied.)

It's hard to get the code right without a good test case, and with
aboriginal in pieces at the moment (ccwrap rewrite, switching over to
musl) I haven't got a convenient chroot set up and am reluctant to test
stuff as root on my work system (without which it can't create /dev
nodes, fifos, and so on).

Also, I still have todo items. It should probably use the uid/gid fields
when running as root, for example. (Create preserves 'em, but extract
doesn't set them.)

Thanks,

Rob

 1395922245.0