[Toybox] [Patches] - Some more static analysis fixes

Ashwini Sharma ak.ashwini1981 at gmail.com
Mon Oct 6 22:50:07 PDT 2014


Hi Rob, List,

Attached are few more static analysis fixes. This includes issues like
resource leaks, logical dead codes etc...

chgrp.c: Issue is in case when CFG_FREE and verbose mode enabled. Garbage
output was there.

comm.c: loop error

id.c: single build issue for OLD_TOYs, same issue is there with some other,
e.g. __mv__

mountpoint.c : logically dead code, as __temp __ is initialized with 1

Do have a look, your inputs are welcome.

regards,
Ashwini
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0003.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: chgrp.c.patch
Type: application/octet-stream
Size: 570 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0048.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: comm.c.patch
Type: application/octet-stream
Size: 363 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0049.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fdisk.c.patch
Type: application/octet-stream
Size: 437 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0050.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: getty.c.patch
Type: application/octet-stream
Size: 356 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0051.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: id.c.patch
Type: application/octet-stream
Size: 474 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0052.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: insmod.c.patch
Type: application/octet-stream
Size: 447 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0053.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: losetup.c.patch
Type: application/octet-stream
Size: 606 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0054.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: modprobe.c.patch
Type: application/octet-stream
Size: 849 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0055.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: netcat.c.patch
Type: application/octet-stream
Size: 419 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0056.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nohup.c.patch
Type: application/octet-stream
Size: 399 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0057.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tftpd.c.patch
Type: application/octet-stream
Size: 318 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0058.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xwrap.c.patch
Type: application/octet-stream
Size: 299 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141007/4155ba1d/attachment-0059.obj>


More information about the Toybox mailing list