[Toybox] [Patches] - Some more static analysis fixes

[Ashwini Sharma]

Hi Rob,

--- cp.c.patch:

Why this change?

-    if (CFG_CP_MV && toys.which->name[0] == 'm') rc = rename(src,
TT.destname);
+    if (CFG_CP_MV && toys.which->name[0] == 'm' && (toys.optflags &
FLAG_f))
+      rc = rename(src, TT.destname);

$ strace mv umount umount.old 2>&1 | grep rename
rename("umount", "umount.old")          = 0

in case of mv __rename()__ is tried at first. The issue handled is in case
when user
gives option __-i__

thats why this extra check for mv.

regards,
Ashwini

On Fri, Oct 10, 2014 at 8:10 PM, Rob Landley <rob at landley.net> wrote:

> On 10/10/14 00:20, David Seikel wrote:
> > On Thu, 09 Oct 2014 23:43:25 -0500 Rob Landley <rob at landley.net> wrote:
> >
> >> --- getty.c.patch:
> >>
> >> I actually have a pending cleanup to getty I haven't checked in for
> >> ages because I haven't got a serial port setup lying around to test.
> >> It redoes the speed calculatons to look like:
> >
> > Er, serial port console on a VM isn't good enough to test with?
>
> Emulated serial console doesn't care about bit rate, because it's not
> breaking things down into bits. (It works at the byte level.)
>
> And yes, this sometimes has side effects:
>
> http://lkml.iu.edu/hypermail/linux/kernel/0802.0/2142.html
>
> Rob
> _______________________________________________
> Toybox mailing list
> Toybox at lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20141013/f7e916f6/attachment-0004.htm>