[Toybox] [Patch] - touch, kill and umount fixes

Ashwini Sharma ak.ashwini1981 at gmail.com
Thu Sep 18 03:38:45 PDT 2014


Hi Rob,

Attached are the patches. This has fixes for

touch:
1.  while setting access or modify times of a file, this was causing a hang
due to non-increment of ss.

2.  handling the time format for __-d__ option as per the spec (
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/touch.html).

kill:

3. prints signal number along with signal names while listing and
vice-versa if an argument is given to the __-l__ option. This has changes
in lib.c + kill.c

umount:

4. __-n__, as per the LSB spec, it will skip updating /etc/mtab. In toybox
case, you
   skipped reading mount list. This doesn't resolve if the device is given
to umount.

   // We use the list both for -a, and to umount /dev/name or do losetup -d
-  if ( !access(pm, R_OK))
+  if (!(toys.optflags & FLAG_n) && !access(pm, R_OK))
     mlrev = dlist_terminate(mlsave = xgetmountlist(pm));


e.g. umount -n /dev/sda1,

this fails, as this doesn't figure out the mountpoint to be umount'ed.

thanks,
Ashwini
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20140918/6946b9e7/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: touch.c.patch
Type: application/octet-stream
Size: 1940 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20140918/6946b9e7/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kill.c.patch
Type: application/octet-stream
Size: 1242 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20140918/6946b9e7/attachment-0001.obj>


More information about the Toybox mailing list