[Toybox] [PATCH 1/2] Cleanup pass on cut.

[Rob Landley]

On 08/29/2015 08:09 PM, Daniel K. Levy wrote:
> Cleanup pass on cut.

Large one, requiring a bit of time to read through. :)

I also took a look at your suggestion to look at
http://lcamtuf.coredump.cx/afl/ and it does seem theoretically useful: 
it's being used to test a bunch of other userspace packages. However,
the README says in step 2:

http://lcamtuf.coredump.cx/afl/QuickStartGuide.txt

2) Find or write a reasonably fast and simple program that takes data from
   a file or stdin, processes it in a test-worthy way, then exits cleanly.
   If testing a network service, modify it to run in the foreground and read
   from stdin. When fuzzing a format that uses checksums, comment out the
   checksum verification code, too.

   The program must crash properly when a fault is encountered. Watch out for
   custom SIGSEGV or SIGABRT handlers and background processes.

The toybox test suite (which I just tried and is badly bit-rotted,
sigh) is checking for a lot of things other than _crashes_. (And we
have a lot of signal handlers in various commands, and specifically
lib/lib.c function sigatexit() installs a handler for SIGSEGV and
SIGABRT.)

If somebody wants to point this thing at toybox, I'm all for it,
but I'm not personally likely to get do so any time soon.

Rob

 1440931433.0