[Toybox] Make Errors

[Rob Landley]

On 08/31/2015 12:06 AM, Isaac Dunham wrote:
> On Sun, Aug 30, 2015 at 11:27:57PM -0500, Rob Landley wrote:
>> On 08/30/2015 08:57 PM, Brent Hostetler wrote:
>>> I could use some help trying to build toybox.
>>>
>>>
>>> I have tried building the last three versions and get the same basic errors:
>>>
>>> [rking at rkmini toybox-0.5.2]$ make defconfig
>>> cc -o kconfig/conf kconfig/conf.c kconfig/zconf.tab.c -DKBUILD_NO_NLS=1 \
>>>         -DPROJECT_NAME=\"ToyBox\"
>>> In file included from kconfig/zconf.tab.c:158:0:
>>> kconfig/zconf.hash.c:161:43: warning: ‘kconf_id_strings_contents’ is
>>> static but used in inline function ‘kconf_id_lookup’ which is not static
>>>  #define kconf_id_strings ((const char *) &kconf_id_strings_contents)
>>>                                            ^
>>
>> How is that inline? The code in kconfig/zconf.hash.c doesn't mark it
>> inline. It's just a function. 
> 
> The definition you need to look at is on lines 162-166.
> It's defined as __inline if you use GCC in a c89-based variant.
> 
> (Yes, I looked at the wrong function myself at first.)

Does this fix it then?

--- a/kconfig/zconf.hash.c_shipped
+++ b/kconfig/zconf.hash.c_shipped
@@ -159,9 +159,6 @@ static struct kconf_id_strings_t kconf_id_strings_contents =
     "enable"
   };
 #define kconf_id_strings ((const char *) &kconf_id_strings_contents)
-#if defined(__GNUC__) && __STDC_VERSION__ < 199901L
-__inline
-#endif
 struct kconf_id *
 kconf_id_lookup (register const char *str, register unsigned int len)
 {

Works for me with or without. No idea why it was _there_ to
be honest. (And I still dunno why gcc 5.2.0 would get
this _inconsistent_ so it both inlined it and didn't,
thus breaking?)

Somebody else said that they needed to add -ltinfo because they hit
https://forums.opensuse.org/showthread.php/446927-missing-library-libtinfo-so-5
or similar, but they did it as some sort of github bug report or
something that I'm not sure how to reply to. (I'm basically ignoring
it until they post it to the mailing list.)

That part sounds like ncurses version skew. Wondering why I'm not
suing it in toybox proper?

I need to bump up the kconfig rewrite on my todo list. (It's also
blocking my attempts to build on bsd.)

> Thanks,
> Isaac

Rob

 1440999938.0