[Toybox] [PATCH] Fix ps.c build.

Rob Landley rob at landley.net
Sun Jul 19 21:59:12 PDT 2015


On 07/18/2015 04:09 PM, enh wrote:
> ping.
> 
> On Fri, May 15, 2015 at 4:38 PM, enh <enh at google.com> wrote:
>> Fix ps.c build.
>>
>> Found by clang...
>>
>> external/toybox/toys/pending/ps.c:315:21: error: address of array
>> 'field->title' will always evaluate to 'true'
>> [-Werror,-Wpointer-bool-conversion]
>>         if (!field->title) strcpy(field->title, typos[field->which]);
>>             ~~~~~~~~^~~~~

Indeed, real bug, but ps.c is only about 75% complete. It doesn't
implement "ps ax" yet, or distinguish between dash vs non-dash options.
(That's why I haven't tested the corner cases yet. This is probably the
command that's going to force me to make a run as root aboriginal linux
test case build control image, because I need to control the PID numbers
to get reproducible results...)

I'm writing up release notes as we speak. I've got a half-dozen pending
commits but there's _always_ a half dozen pending commits, so I need to
snapshot and move on and then have the next release more quickly.

Rob

 1437368352.0


More information about the Toybox mailing list