[Toybox] [PATCH] Fix ps.c build.

[enh]

True, but this is a build break for clang (because it's a tautology).
On Jul 19, 2015 9:59 PM, "Rob Landley" <rob at landley.net> wrote:

> On 07/18/2015 04:09 PM, enh wrote:
> > ping.
> >
> > On Fri, May 15, 2015 at 4:38 PM, enh <enh at google.com> wrote:
> >> Fix ps.c build.
> >>
> >> Found by clang...
> >>
> >> external/toybox/toys/pending/ps.c:315:21: error: address of array
> >> 'field->title' will always evaluate to 'true'
> >> [-Werror,-Wpointer-bool-conversion]
> >>         if (!field->title) strcpy(field->title, typos[field->which]);
> >>             ~~~~~~~~^~~~~
>
> Indeed, real bug, but ps.c is only about 75% complete. It doesn't
> implement "ps ax" yet, or distinguish between dash vs non-dash options.
> (That's why I haven't tested the corner cases yet. This is probably the
> command that's going to force me to make a run as root aboriginal linux
> test case build control image, because I need to control the PID numbers
> to get reproducible results...)
>
> I'm writing up release notes as we speak. I've got a half-dozen pending
> commits but there's _always_ a half dozen pending commits, so I need to
> snapshot and move on and then have the next release more quickly.
>
> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20150719/28e90a4c/attachment-0003.htm>