[Toybox] [PATCH] Fix find -perm.

[Rob Landley]

On 11/13/2015 09:40 PM, enh wrote:
> On Fri, Nov 13, 2015 at 6:53 PM, Rob Landley <rob at landley.net> wrote:
>> On 11/13/2015 07:52 PM, enh wrote:
>>> Yeah, we still have two different bug databases. This is the one you
>>> can't see, but there's nothing in the bug that isn't in the commit message.
>>>
>>> Fun fact: you can append a commit message to random internal bugs by
>>> adding a "Bug: " line with one of these numbers or URLs ☺
>>>
>>> I usually don't add the bugs because they're meaningless to you, but I
>>> don't really have a way to communicate "this was found by some other
>>> internal team, not by me".
>>
>> I assume you forward stuff from Google/Android the way Jose Bollo
>> forwarded stuff from Tizen and Ashwini Sharma/Hyejin Kim from Company
>> Carefully Remaining Nameless and so on.
> 
> not really. Gilad's working on Brillo, and they're at least as
> pro-AOSP as my team. but PMs and release teams are all focused on the
> internal databases, so the internal bug databases still tend to be the
> canonical ones, sadly.

Everybody's busy. :)

>> I still have a local diff against find left over from
>> http://lists.landley.net/pipermail/toybox-landley.net/2015-September/004464.html
>> and I don't remember if this was one of the two issues I was trying to
>> fix then, or if it's a third.
> 
> i did notice that the test for an unterminated -exec fails; that was
> one of the bugs you thought you'd fixed. i ought to run all the tests
> more frequently, but -- in part because there are so many failures --
> i tend to just run the tests for the command i'm working on.

One of my todo items is a testsuite triage but I may not get to do it
properly until it's nearing time for 1.0. One of the balls I'm juggling
is a qemu-based test environment under aboriginal for testing root
stuff, but it's nontrivial to make things like "ps" deterministic even
with an emulator. I need to carve out a large contiguous chunk of focus
to properly design it, and those are in short supply...

(To be honest what I've been working on is adding ps --sort, as a
prerequisite for merging top into ps, and the _other_ big prerequisite
is factoring out the column alignment code from "ls" and putting it in
lib where ps and top can get at it. And then I need to take the
fontmetrics stuff that hexedit is currently the only user of and make
sure that top gets the measurements right when it's got a utf8 username
and command name and so on to display. And then once THAT's in implement
watch and less and more and the other things using the display window
concept that top also needs...)

>> (Sorry, modifying a dozen commands in
>> parallel, balls tend to get dropped... Currently packing for my trip to
>> Santa Diego and Santa Clara next week, might not get to this until I'm
>> on the plane.)
> 
> at least it's not Japan this time!

This time. :)

>> Rob

Rob

 1447473139.0