[Toybox] [PATCH] Fix netstat -p.

[Rob Landley]

On 09/08/2015 09:19 PM, enh wrote:
> On Tue, Sep 8, 2015 at 10:53 AM, Rob Landley <rob at landley.net> wrote:
>>> yeah, the other patch looks sensible but is wrong. (that was what i
>>> tried first too :-) )
>>
>> Basically what I told the other committer, but I'm trying to be more
>> encouraging to other developers and less of a bottleneck.
>> (I still totally should have named this project dorodango.)
> 
> want to commit the other lsof patch then? :-)

Grr. Too many balls in the air...

Work sprung another pending trip to Japan on me, only for a week this
time, but I fly out this coming Saturday and have to do a number of
non-toybox things by then (mostly http://nommu.org/jcore related).

I backed out the lsof changes I was working on and checked in yours, I
can redo my stuff on top of it. (Possibly after Japan.)

>> Besides, "fixed it for them" is valuable, and the point of the pending
>> directory is so I'm not going to forget to fix it properly if I ever
>> make it that far down my todo list. :)
> 
> fwiw, people definitely use netstat on Android and this was the first
> bug report i've had. (and they were only trying to use netstat -p
> because lsof couldn't decode sockets, which is now fixed too.)

Yay.

> that said, i did just notice that -e doesn't work right (it doesn't
> add the extra user/inode columns to the tcp output), and non-wide mode
> (i.e. without -W) doesn't truncate IP addresses. patch attached.

And applied.

Thanks,

Rob

 1441772595.0