[Toybox] [PATCH] Fix touch(1) date parsing on tzcode-derived systems.

enh enh at google.com
Mon Aug 1 09:48:30 PDT 2016


ping. (this was found by folks trying to automate some file system testing,
so i'd rather not hold them up...)

On Fri, Jul 29, 2016 at 1:19 PM, enh <enh at google.com> wrote:

> The IANA tzcode implementation of mktime (used on Android and BSDs) sets
> errno in some cases where it doesn't return -1 to indicate failure, so the
> existing test always failed on those systems.
>
> I don't think glibc ever sets errno (which is fine by ISO C, but not
> POSIX).
>
> Other uses of mktime in toybox are already fine. This one would have been
> caught by the existing tests if I was running them on the device :-(
> ---
>  toys/posix/touch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>



-- 
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20160801/a049fac5/attachment.htm>


More information about the Toybox mailing list