[Toybox] [PATCH] chown/chgrp with unknown numeric ids

darken darken at darken.eu
Sat Aug 20 04:01:47 PDT 2016


>
> I was grinding through my todo list last night and fixed this, and only
> just noticed replying to your message that you'd attached a patch.
> (Oops. Sorry.)


:-|, well at least it's fixed.

The fixes look fairly similar. I need to update tests/chown.test and
>
tests/chgrp.test to actually check for this usefully. (Poking at that now.)
>

Why return `unsigned` instead of `uid_t`/`gid_t` from the get uid/gid
methods?

By the way, I have another patch for the test applet:
https://github.com/landley/toybox/pull/47

~Matthias

2016-08-19 23:56 GMT+02:00 Rob Landley <rob at landley.net>:

> On 08/14/2016 12:54 PM, darken wrote:
> > The issue is that chown/chgrp would error exit if it was passed an
> > unknown numeric uid/gid.
>
> I was grinding through my todo list last night and fixed this, and only
> just noticed replying to your message that you'd attached a patch.
> (Oops. Sorry.)
>
> The fixes look fairly similar. I need to update tests/chown.test and
> tests/chgrp.test to actually check for this usefully. (Poking at that now.)
>
> Thanks,
>
> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20160820/acabdc57/attachment-0001.htm>


More information about the Toybox mailing list