[Toybox] [BUG] ls applet ignores options if CONFIG_LS_COLOR is not set

Rob Landley rob at landley.net
Wed Dec 7 21:09:15 PST 2016


On 12/07/2016 10:52 PM, Rob Landley wrote:
> On 12/04/2016 10:29 PM, Rob Landley wrote:
>> On 12/04/2016 08:36 PM, darken wrote:
>>> If `CONFIG_LS_COLOR` is not set the `ls` applet doesn't take options and
>>> either ignores them or says `ls: Unknown option...`.
>>>
>>> Some testoutput:
>>> https://github.com/landley/toybox/issues/57
>>>
>>> Seems to be caused by commit:
>>> https://github.com/landley/toybox/commit/48c75324f758e77ca3ba64072a48a7407e765570
>>> Reverting it fixes this.
>>
>> Huh.
>>
>> In generated.flags.h:
>> #define OPTSTR_ls
>> "(^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^As^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A^A"
>>
>> Yeah, that's not right. Digging into it.
>>
>> Thanks for the heads up,
>>
>> Rob
>>
> 
> Sigh, nevermind. Regression test failed in the clean tree. (_After_I
> checked it in, of course.) Fixing...
> 
> Rob

Ahem. Ok, try _now_.

Rob


More information about the Toybox mailing list