[Toybox] Stat %Z - What are valid values?

Rob Landley rob at landley.net
Fri Dec 30 13:51:11 PST 2016


On 12/30/2016 01:39 PM, enh wrote:
> 1928-04-26 17:31:55.746667836 18446744072394174731

Really we can partially blame posix here for not specifying whether
time_t is signed or unsigned. (If it's unsigned it can't represent times
before January 1, 1970, as the code on the left is doing. And there
_are_ times before then. So I think we have to treat it as signed and go
"32 bit timestamps gotta go away before 2038".)

Linus' opinion on unsigned time_t is here (spoiler: it's "no"):

  https://lkml.org/lkml/2011/8/31/246

> two patches attached.
...
> the other
> removes void* casts unnecessary since POSIX 2008 and fixes the
> strftime buffer length argument.

Why did you remove the comment block in the second patch? (Is it wrong?)

Rob


More information about the Toybox mailing list