[Toybox] [PATCH] dmesg -w output shouldn't be buffered.

enh enh at google.com
Fri Dec 9 16:07:15 PST 2016


not particularly --- this would be the first time i've actually
managed to get it done on friday in several months! but i've certainly
got plenty of other stuff i should be doing, so no hurry.

i'm not sure whether you really meant wget (which we don't even
build), but dmesg is certainly a bit weird now: a lot of the options
only make sense for one dmesg implementation or the other. and i'm
assuming you're not prepared to say "screw Linux < 3.5" and just
delete the old implementation.

On Fri, Dec 9, 2016 at 3:53 PM, Rob Landley <rob at landley.net> wrote:
> On 12/09/2016 05:32 PM, enh wrote:
>> I don't think it makes much difference whether we use setvbuf(3) or flush
>> at the end of each line; I went with the latter just because when we're
>> coloring, each line is made up of several separate chunks.
>> ---
>>  toys/lsb/dmesg.c | 2 ++
>>  1 file changed, 2 insertions(+)
>
> Given that I assume we've already missed your friday merge deadline, I'd
> like to take some time this weekend to go over the new wget properly.
>
> Rob



-- 
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.



More information about the Toybox mailing list