[Toybox] [PATCH] Add support for getprop -Z

Tom Cherry tomcherry at google.com
Wed Feb 17 16:31:35 PST 2016


Thank you for taking a look.  I have attached a new patch that is
diffed against current.

Tom

On Wed, Feb 17, 2016 at 3:56 PM, Rob Landley <rob at landley.net> wrote:
> On Wed, Feb 17, 2016 at 4:59 PM, Tom Cherry <tomcherry at google.com> wrote:
>> Ping - Can this be looked at?
>>
>> Thank you
>> Tom
>>
>> On Mon, Feb 8, 2016 at 3:57 PM, Tom Cherry <tomcherry at google.com> wrote:
>>>
>>> Apologies for the previous email mangling the patch.  This one should
>>> be correct...
>
> It went on my todo list because #including selinux.h directly is
> ordinarily frowned upon (there's a lib/lsm.h wrapping that and smack
> into a common interface), but this is a toys/android command so it
> only builds on android anyway, so...
>
> $ git am attachment.bin
> Applying: Add support for getprop -Z
> error: patch failed: toys/android/getprop.c:21
> error: toys/android/getprop.c: patch does not apply
> Patch failed at 0001 Add support for getprop -Z
> When you have resolved this problem run "git am --resolved".
>
> Hmmm... [dig dig...]
>
> The whitespace damage is that the "previous" file version it expects
> to apply to ends with "#else", which went away in the first cleanup
> (commit 5b493dc48db0 in April of last year).
>
> There have been three commits to this command since the original
> submission, could you rediff against current please?
>
> Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-for-getprop-Z.patch
Type: text/x-patch
Size: 3406 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20160217/7567a2a1/attachment-0002.bin>


More information about the Toybox mailing list