[Toybox] [PATCH] Implement "insmod -".

enh enh at google.com
Fri Feb 19 11:32:13 PST 2016


early to ping, i know, but should i wait for this to go in before
doing my weekly sync, or catch it next week?

On Thu, Feb 18, 2016 at 4:30 PM, enh <enh at google.com> wrote:
> Also use finit_module if available. Given that "insmod -" requires
> init_module, maybe this isn't a worthwhile optimization. Given that
> "insmod /actual/file.ko" is the common use case, maybe it is.
>
> Fix a bug in readfileat where *plen would be corrupted if you didn't supply
> your own buffer (because ibuf is 0 in that case, not a pointer to the start
> of the allocated space).
> ---
>  lib/lib.c           |  4 ++--
>  toys/other/insmod.c | 32 ++++++++++++++++++--------------
>  2 files changed, 20 insertions(+), 16 deletions(-)



-- 
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.

 1455910333.0


More information about the Toybox mailing list