[Toybox] [PATCH] new Android toy: log

enh enh at google.com
Wed Jun 22 15:53:47 PDT 2016


On Tue, Jun 21, 2016 at 8:53 PM, Rob Landley <rob at landley.net> wrote:
> On 06/21/2016 05:29 PM, enh wrote:
>> On Tue, Jun 21, 2016 at 2:13 PM, Rob Landley <rob at landley.net> wrote:
>>> Don't #ifdef ANDROID on something that already depends on
>>> TOYBOX_ON_ANDROID, we only compile it when it's buildable (compile-time
>>> probes set the symbol). Typing "make log" at the command line assumes
>>> you know what you're doing, and building an empty command isn't an
>>> improvement.
>>
>> like i say each time this comes up :-) --- i need to be able to "make"
>> on the host to be able to run all your stuff to generate the generated
>> files. we could add bogus implementations to portability, but then you
>> end up with quite a lot of fake android crap in there...
>
> Ah, we have had this discussion before. It's already there (since 2014):
>
>   NOBUILD=1 make
>
> That regenerates headers then stops before trying to compile the result.

okay, i can live with that. it was mildly convenient to be able to
build for host and target from the same directory (and thus .config
file), but i can live without.

> Rob



-- 
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.


More information about the Toybox mailing list