[Toybox] [PATCH SET] Fix test harness issues and fix tests

[Andy Chu]

On Sun, Mar 20, 2016 at 9:08 PM, Rob Landley <rob at landley.net> wrote:
> On 03/18/2016 08:24 PM, Andy Chu wrote:
>> This is a pretty big cleanup, still in progress, but I think these
>> parts are ready to merge.
>
> It's a large lump, some bits of which I disagree with. Should I apply
> and then apply an undo patch, or chip off bits?

Yeah sorry about the big lump, but the original history is super messy
-- there was a lot of churn of going back and forth as I was figuring
things out and learning the code.

If you read the commit description, it seems disjointed, but
everything is related to producing a "green build" (passing tests).
If you compare "make test" before and after, all the changes show up
there, and I think it's good progress.

But I have another large lump coming up (call it patch 0004)!  It adds
some significant functionality (ASAN and all that, which found some
good bugs), as well as fixing test environment issues.

There was a recurring theme in the test failures -- under "make test",
you would have a directory in your PATH with ALL toybox binaries.
Under "make test_sed", you would only have sed in that dir.  Patches
1-3 don't fix that but patch 4 does.

Patch 0004 also addresses some of the issues below.  I changed it to
"make generated/single/sed" instead of "make sed", and this eliminates
the namespace clash.  I kept "make sed" as a phony target for backward
compatibility, but personally I would prefer to remove them.

I'll respond in detail to the issues below after I send it out ... I
can definitely change things based on your feedback, but it might have
to be on top of this patch... patch #5 on top of #4 to address your
feedback.

Andy

 1458536266.0