[Toybox] [PATCH] Clarify fallocate help text.

enh enh at google.com
Fri Sep 30 15:05:13 PDT 2016


-l isn't optional, and fallocate accepts the same suffixes as truncate.

(As do many other commands. We might prefer to just *not* document
this anyway and have to teach people that toybox [mostly] accepts
the same set of suffixes everywhere. dd is a place where the suffixes
differ, but the fix there might also be to make atollx support the
whole dd set.)

I did watch someone work out 3221225472 so they could supply it as an
argument to fallocate, though. A half-way solution might be to always
have terminology like "-l New length (accepts usual suffixes)", rather
than explicitly write them out? (We're already not documenting that
2K==2k, and if we do in future accept the full dd set everywhere,
that's two lines of help in a lot of commands.)

Bug: 31638516
---
 toys/other/fallocate.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Clarify-fallocate-help-text.patch
Type: text/x-patch
Size: 1600 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20160930/818dbeea/attachment-0003.bin>


More information about the Toybox mailing list