[Toybox] [PATCH] file(1) should recognize gzip data too.

Rob Landley rob at landley.net
Mon Apr 3 14:52:19 PDT 2017


// GNU file shows the source OS and timestamp too but busybox and toybox
// leave those unknown/blank, so reporting them isn't obviously useful.

Busybox hasn't got "file". I agree reporting them isn't obviously
useful, but I think I'm yanking the comment (or at least moving it to
the checkin comment).

And while we're at it, in zip detection...

    int ver = (int)(char)(toybuf[4]);

A double typecast is never a good sign, but here we compile with
-funsigned-char (for consistency across architectures) which toybuf[4]
already _is_ an instance of so... what is this doing? Did they mean to
typecast it to (signed char) and then... llvm complained maybe? Can the
zip version be negative?

I'm confused!

Rob



More information about the Toybox mailing list