[Toybox] [PATCH] killall should kill scripts too.

Rob Landley rob at landley.net
Sun Dec 17 09:40:51 PST 2017


On 12/17/2017 11:20 AM, Rob Landley wrote:
> Sigh. You argument that "we can't just do something easily explained but
> must copy ubuntu's magic edge cases exactly" implies I need to
> understand ubuntu's magic edge cases, which are nonobvious.

I should clarify: what I'm uncomfortable with is the need to read
multiple /proc files per process, because the speed of lsof is just
_sad_ and the cpu usage of top is unpleasant. (Part of the reason I
haven't finished cleaning up lsof yet is I still hope to be able to
speed it up somehow, which is a largeish time sink every time I turn my
attention to it.)

Having killall need to do similar grinding over a large number of
processes seems unnecessary. That said, it looks like to match ubuntu's
killall we would need to read two files _and_ stat /proc/$$/exe.

Rob



More information about the Toybox mailing list