[Toybox] ps crashes

[enh]

a new report today (from a build from yesterday that does have the `if
(new->child == DIRTREE_ABORTVAL) new->child = 0;` patch):

pid: 16725, tid: 16725, name: ps  >>> ps <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x10
x0   0000000000000000  x1   0000000000000000  x2   0000000000000000
x3   0000007fc05036e8
x4   0000007ccc157174  x5   0000007ccc01d08b  x6   7365636f72702e64
x7   616964656d2e7373
x8   0000000000000000  x9   0000000000000001  x10  0000000000004001
x11  0000000000000000
x12  000000000000000f  x13  0000007ccc790c94  x14  0000007ccc790938
x15  0000000000000001
x16  0000007ccc7ae2c0  x17  0000007ccc74d80c  x18  000000000000000d
x19  0000007ccc0350c0
x20  0000000000000000  x21  000000556e5bf790  x22  000000556e5bc768
x23  0000000000000654
x24  0000000000000040  x25  0000007ccc035010  x26  0000000000000000
x27  0000000000000000
x28  0000000000000000  x29  0000007fc0503ee0  x30  000000556e593470
sp   0000007fc0503eb0  pc   000000556e593478  pstate 0000000080000000

Stack Trace:
  RELADDR           FUNCTION                     FILE:LINE
  0000000000034478  get_threads+228
external/toybox/toys/posix/ps.c:917 (discriminator 1)
  000000000000da2c  dirtree_handle_callback+36
external/toybox/lib/dirtree.c:112
  000000000000db38  dirtree_recurse+128
external/toybox/lib/dirtree.c:156
  000000000000da84  dirtree_handle_callback+124
external/toybox/lib/dirtree.c:115
  0000000000033808  ps_main+952
external/toybox/toys/posix/ps.c:1238
  0000000000013770  toy_exec+92
external/toybox/main.c:166 (discriminator 1)
  0000000000013334  toybox_main+48
external/toybox/main.c:179 (discriminator 1)
  0000000000013838  main+124                     external/toybox/main.c:237

as before, this was just a crash collected during testing. no repro
steps and (afaik) this is the first crash since March :-/

On Wed, Mar 22, 2017 at 12:37 PM, Rob Landley <rob at landley.net> wrote:
> On 03/22/2017 01:18 PM, enh wrote:
>> (For those following along at home, a fix was merged yesterday.)
>
> And the reason I didn't change what lib/dirtree.c was doing is stuff
> like "mv" is making use of the distinction. :P
>
> Rob



-- 
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.