[Toybox] [PATCH] Make find -exec + obey ARG_MAX just like xargs.
enh
enh at google.com
Thu Nov 16 14:20:20 PST 2017
correspondingly, i've made bionic's _SC_ARG_MAX return a constant
128KiB again. we might want to actually just hard-code 128KiB for both
find and xargs, but making find and xargs the same first seemed like a
good idea regardless.
let me know if you want me to send a "make find/xargs use a constant"
patch too (glibc removed ARG_MAX, so i think we'd want a #ifndef in
portability.h).
On Thu, Nov 16, 2017 at 2:17 PM, enh <enh at google.com> wrote:
> This isn't ideal, but it matches xargs and none of us is likely to have
> time to do the best possible thing any time soon.
>
> Bug: http://b/65818597
> Test: ./toybox find /usr/local/google/ndkports/ -exec echo {} +
> ---
> toys/posix/find.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
--
Elliott Hughes - http://who/enh - http://jessies.org/~enh/
Android native code/tools questions? Mail me/drop by/add me as a reviewer.
More information about the Toybox
mailing list