[Toybox] [PATCH] bc: Add to pending

Gavin Howard gavin.d.howard at gmail.com
Tue Aug 7 23:19:25 PDT 2018


Hello,

I thought I might be able to help with the changes. Attached is a
standalone patch (so ignore the previous one) that has the changes you
listed.

It also has a recent fix for a segfault on a random bit of invalid input,
as well as some warning fixes, in case you want those also.

Gavin Howard

On Tue, Aug 7, 2018 at 10:12 PM Rob Landley <rob at landley.net> wrote:

> On 08/07/2018 10:22 AM, Gavin Howard wrote:
> > Hello,
> >
> > Since it has been a month, I thought I would ping.
>
> I admit the drama circling around it's been a bit of a turn-off, but
> mostly I
> just forgot. Let's see, why did I not add this immediately...
>
> Because it adds tests/files/bc/{parse,print,arctan}.txt to .gitignore and
> if
> anything goes in there it should be read only, so I had to remember to
> follow-up
> with cleanups after applying it (otherwise it's easy to forget and stumble
> on it
> a year later and wonder what else I missed)...
>
> The tests all run in a scratch directory (if you "make test_bc" it should
> be
> generated/testdir/testdir), so you can put generated files in the current
> directory; generated/testdir gets blown away each time you run
> scripts/test.sh
> and the "testdir" under it gets rm -rf'd and recreated between each test if
> you're testing multiple commands.
>
> I'll try to get to that this weekend, sorry for the delay.
>
> Rob
> _______________________________________________
> Toybox mailing list
> Toybox at lists.landley.net
> http://lists.landley.net/listinfo.cgi/toybox-landley.net
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20180808/872bc635/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-bc-and-its-tests-to-pending.patch
Type: text/x-patch
Size: 200261 bytes
Desc: not available
URL: <http://lists.landley.net/pipermail/toybox-landley.net/attachments/20180808/872bc635/attachment-0003.bin>


More information about the Toybox mailing list